Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game Center: Add getting signature for verification teamPlayerID #4

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

PoqXert
Copy link
Contributor

@PoqXert PoqXert commented Mar 19, 2021

generateIdentityVerificationSignatureWithCompletionHandler method generate data for verification playerID.
For get verification data for teamPlayerID need use fetchItemsForIdentityVerificationSignature method.

@@ -336,7 +336,7 @@
ret["signature"] = [[signature base64EncodedStringWithOptions:0] UTF8String];
ret["salt"] = [[salt base64EncodedStringWithOptions:0] UTF8String];
ret["timestamp"] = timestamp;
if (@available(iOS 13, *)) {
if (@available(iOS 13.5, *)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to change this part?
Docs says it's available even at lower than 13 iOS version. It's actually playerID that got deprecated at 13 version.
And having generateIdentityVerificationSignatureWithCompletionHandler deprecated at 13.5 shouldn't affect that part.
This should probably stay as it is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchItemsForIdentityVerificationSignature available in 13.5+ and teamPlayerID can't be verify at lower version. If return teamPlayerID you get signature error on server-side.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe using gamePlayerID would be better then? Since playerID is deprecated at 13.0, I'm not sure it's a good idea to leave it hanging.
Found this thread seems like there is no way around that issue.

@naithar naithar merged commit 29366c5 into godot-sdk-integrations:master Mar 19, 2021
@PoqXert PoqXert deleted the fix-verification branch March 19, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants