Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Streamline names and contents of releases and artifacts #27

Merged
merged 2 commits into from
Dec 18, 2022
Merged

CI: Streamline names and contents of releases and artifacts #27

merged 2 commits into from
Dec 18, 2022

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Dec 17, 2022 •
edited
Loading

Packaging:

  • Use FBX2glTF-<platform>-<arch> format consistently for binaries.
  • Zip binary + licenses for the GitHub Releases.
  • Rename licenses to FBX-SDK-License.{rtf,txt} and FBX2glTF-License.txt.
  • Include licenses together with the artifacts for each platform.
  • Don't upload the licenses as a separate artifact, it gets zipped so it's not
    convenient. We still upload them as files to GH Releases though which we can
    link directly.

CI setup:

  • Rename jobs for consistency.
  • Bump to actions/checkout@v3 and setup-python@v4.

@akien-mga akien-mga requested a review from fire December 17, 2022 21:37
@akien-mga akien-mga force-pushed the ci-streamline-packages branch 8 times, most recently from 3a782ca to 11f9734 Compare December 17, 2022 23:04
@akien-mga akien-mga marked this pull request as ready for review December 17, 2022 23:05
@akien-mga
Copy link
Member Author

Test release on my fork to validate the changes: https://github.com/akien-mga/FBX2glTF/releases/tag/v0.13.0-p1

@akien-mga akien-mga force-pushed the ci-streamline-packages branch 3 times, most recently from 44e3fcf to 4031f06 Compare December 17, 2022 23:30
@akien-mga
CI: Streamline names and contents of releases and artifacts
b24e56c 
Packaging:

- Use `FBX2glTF-<platform>-<arch>` format consistently for binaries.
- Zip binary + licenses for the GitHub Releases.
- Rename licenses to `FBX-SDK-License.{rtf,txt}` and `FBX2glTF-License.txt`.
- Include licenses together with the artifacts for each platform.
- Don't upload the licenses as a separate artifact, it gets zipped so it's not
  convenient. We still upload them as files to GH Releases though which we can
  link directly.

CI setup:

- Rename jobs for consistency.
- Bump to actions/checkout@v3 and setup-python@v4.
@akien-mga
Update README with more license and download details
05ff763 
Takes into account the artifact/release changes from the previous commit.
@akien-mga
Copy link
Member Author

akien-mga commented Dec 17, 2022 •
edited
Loading

Alright, after a bunch of iterations, I believe this is now ready to merge.

Test release on my fork: https://github.com/akien-mga/FBX2glTF/releases/tag/v0.13.0-p3
Still building at the time of posting, but it should eventually include:

  • FBX2glTF-linux-x86_64.zip
  • FBX2glTF-macos-x86_64.zip
  • FBX2glTF-windows-x86_64.zip
  • FBX2glTF-License.txt
  • FBX-SDK-License.rtf

Once merged here, we could tag v0.13.0-p1 on this repo and https://github.com/godotengine/FBX2glTF/releases/latest links would automatically resolve to the correct downloads.

@Calinou Calinou added the enhancement New feature or request label Dec 17, 2022
@akien-mga akien-mga mentioned this pull request Dec 18, 2022
Merged
fire
fire approved these changes Dec 18, 2022
View reviewed changes
Copy link
Member

@fire fire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a read over of the code and executed the binary for windows once with https://sketchfab.com/3d-models/sensei-4-cc86a15388ab403baff5c7a4b4d3eefc

image

The import erroring can be debugged separately in a different pr.

Especially since I can't reproduce in Godot Engine.

@akien-mga akien-mga merged commit 65550bf into godotengine:master Dec 18, 2022
@akien-mga akien-mga deleted the ci-streamline-packages branch December 18, 2022 08:37
@fire fire mentioned this pull request Dec 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akien-mga @fire @Calinou