abort run if user cancels (C-g) a scene/script selection. #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanLovato
requested changes
Sep 8, 2020
Collaborator
NathanLovato
left a comment
NathanLovato
left a comment
There was a problem hiding this comment.
Could you remove the TODO note from the source code?
Also, may I ask what this feature is and how I can test it? Does it only work if you don't have projectile or ivy?
gdscript-godot.el
Outdated
| (interactive) | ||
| (gdscript-godot--debug-options-handler debug-options | ||
| (gdscript-godot--run-command "-d" debug-options (gdscript-godot--select-scene)))) | ||
| (let ((scene (gdscript-godot--select-scene current-prefix-arg))) ;; TODO - debug and force select using prefix. need to tweak this sometime. |
Collaborator
There was a problem hiding this comment.
Please don't leave comments and, in particular, TODOs in the code. If a feature is unfinished or has a known bug, it should be addressed before merging. If it's a note for a future improvement instead, please open a new issue.
Contributor
Author
There was a problem hiding this comment.
Prior to this fix if you hit C-g (I use projectile) it still ran the default scene whereas it should abort.
Re todo, yes I'll address that tomorrow. End of day here.
NathanLovato
added
bug
NathanLovato
approved these changes
Sep 9, 2020
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.