Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we add versioning to this? #60

Closed
Ughuuu opened this issue Nov 6, 2024 · 4 comments
Closed

Can we add versioning to this? #60

Ughuuu opened this issue Nov 6, 2024 · 4 comments

Comments

@Ughuuu
Copy link
Contributor

Ughuuu commented Nov 6, 2024

I was using latest main and yesterday a breaking change was added and now my builds fail: https://github.com/libriscv/godot-sandbox/actions/runs/11711734886/job/32620906679

Can we version this repo somehow? Eg. starting from now lets say the branch instead of main there is 1.0, and version keep coming, and every breaking change adds a version.

@Ivorforce
Copy link
Contributor

Hi, I just commented about the failing build in #61.

Regarding versioning, I agree that's probably a good idea!

For the moment, I'd advise you to depend on a specific git hash or tag though instead of a branch for runners. The recent contribution that broke your build was a bug fix, so it may not even have gotten a major version increase even with versioning.

@Ughuuu
Copy link
Contributor Author

Ughuuu commented Nov 6, 2024

Fair enough. Thanks for responding. Updated the path and now builds work. Thanks for fixing, ill check the cache also.

@dsnopek
Copy link
Contributor

dsnopek commented Nov 7, 2024

Should the GitHub Action be moved to its own repo perhaps?

This repo is a template, which is only meant to be copied when a project is first created - we should be able to change almost anything we want without affecting backwards compatibility.

@paddy-exe
Copy link
Collaborator

I concur with David. As a template the main goal is to provide a functioning project to get started. If you want to have a separate repo with the actions used here so you can pull the updates into your repo that would be a different discussion to have.

@Ughuuu Ughuuu closed this as completed Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants