Fix crash using Object* as parameter #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhehangd
changed the title
akien-mga
reviewed
Mar 29, 2023
| @@ -168,7 +168,9 @@ MAKE_PTRARG_BY_REFERENCE(Variant); | |||
| template <class T> | |||
| struct PtrToArg<T *> { | |||
| _FORCE_INLINE_ static T *convert(const void *p_ptr) { | |||
| return reinterpret_cast<T *>(godot::internal::gde_interface->object_get_instance_binding(*reinterpret_cast<GDExtensionObjectPtr *>(const_cast<void *>(p_ptr)), godot::internal::token, &T::___binding_callbacks)); | |||
| auto gde_obj_ptr = reinterpret_cast<GDExtensionObjectPtr>(const_cast<void *>(p_ptr)); | |||
There was a problem hiding this comment.
Please state the type explicitly instead of using auto.
bruvzg
reviewed
Mar 29, 2023
|
Changed. Just wanted to avoid writing GDExtensionObjectPtr twice before and after reinterpret_cast. |
|
Looks good! Could you squash the commits? See PR workflow for instructions. |
zhehangd
force-pushed
the
fix_obj_ptr_crash
branch
from
41fedec to
093f067
Compare
|
Done |
akien-mga
approved these changes
Apr 1, 2023
|
Thanks! |
|
This PR appears to have caused a regression similar to #1045 When debugging an issue someone found while testing godotengine/godot#77010, I found that Godot appears to be passing |
dsnopek
added a commit
to dsnopek/godot-cpp
that referenced
this pull request
May 23, 2023
dsnopek
added a commit
to dsnopek/godot-cpp
that referenced
this pull request
May 25, 2023
dsnopek
added a commit
to dsnopek/godot-cpp
that referenced
this pull request
May 25, 2023
dsnopek
added a commit
to dsnopek/godot-cpp
that referenced
this pull request
May 25, 2023
dsnopek
added a commit
to dsnopek/godot-cpp
that referenced
this pull request
May 25, 2023
dsnopek
added a commit
to dsnopek/godot-cpp
that referenced
this pull request
May 25, 2023
dsnopek
added a commit
to dsnopek/godot-cpp
that referenced
this pull request
May 25, 2023
dsnopek
added a commit
to dsnopek/godot-cpp
that referenced
this pull request
May 26, 2023
dsnopek
added a commit
to dsnopek/godot-cpp
that referenced
this pull request
May 26, 2023
dsnopek
added a commit
to dsnopek/godot-cpp
that referenced
this pull request
May 26, 2023
dsnopek
added a commit
to dsnopek/godot-cpp
that referenced
this pull request
Jun 7, 2023
…standardize on `Object **` encoding in ptrcall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1020, fixes #1025 (only for
Object*parameter crash,Ref<Object>crash reported recently is a different issue).*reinterpret_cast<GDExtensionObjectPtr *>->reinterpret_cast<GDExtensionObjectPtr>as the real type ofp_ptrisObject*notObject**.