Don't cache null forever if a singleton isn't available yet
#1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
|
Thanks! Since GDExtensions can try to access singletons before they are available, and we don't want to permanently punish a GDExtension for trying, this makes sense to me. However, it would also be great to make the core singletons available a little bit earlier - see PR godotengine/godot#79584 FYI, this will conflict with PR #1176 so one or the other will end up needing to be rebased, depending on which is merged first |
|
This needs a rebase now that #1176 is merged |
Zylann
force-pushed
the
fix_singleton_caching
branch
from
1ffa645 to
47d5eef
Compare
|
Rebased |
dsnopek
requested changes
Jul 22, 2023
# Conflicts: # binding_generator.py
Zylann
force-pushed
the
fix_singleton_caching
branch
from
47d5eef to
548c758
Compare
|
Updated |
dsnopek
approved these changes
Jul 22, 2023
dsnopek
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the third point of issue #1180 (and perhaps the second one if that was the cause all along, but havent checked that yet)
If you call
get_singletontoo early and it returnsnullptr, it would keep returningnullptrforever.