Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compiledb generation to test project and customs loading SConstruct #1213

Closed

Conversation

adamscott
Copy link
Member

Adds compiledb generation to the test project and makes it possible to apply local custom.py files to the main SConstruct build.

This will make it possible to generate "compile_commands.json" in the godotengine/godot-cpp-template project.

Supersedes/depend on #1212

@adamscott adamscott requested a review from a team as a code owner August 15, 2023 19:40
@adamscott adamscott added the enhancement This is an enhancement on the current functionality label Aug 15, 2023
@adamscott adamscott added this to the 4.x milestone Aug 15, 2023
@adamscott adamscott force-pushed the add-compiledb-to-test-project branch from 4b996d5 to cc516a1 Compare August 15, 2023 19:44
@dsnopek
Copy link
Collaborator

dsnopek commented Aug 16, 2023

I'm not sure why we need to add these things to the test project? That project is for running our automated tests and I don't think we really need custom.py or compilation db for that.

On the topic of importing custom.py in the main SConstruct you've already got two other PRs open that seem to aim to do that:

So, I don't think that needs to be replicated again here.

@adamscott
Copy link
Member Author

I'm not sure why we need to add these things to the test project? That project is for running our automated tests and I don't think we really need custom.py or compilation db for that.

You're maybe right. I treated the "test" project as a way to instruct people how to use godot-cpp, but as godotengine/godot-cpp-template exist now, there's less the need to update the test project.

On the topic of importing custom.py in the main SConstruct you've already got two other PRs open that seem to aim to do that:

I completely forgot that I already did a PR for custom files. My bad.

@adamscott adamscott closed this Aug 17, 2023
@akien-mga akien-mga removed this from the 4.x milestone Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archived enhancement This is an enhancement on the current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants