-
-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a separate setup-godot-cpp github action. #1656
Add a separate setup-godot-cpp github action. #1656
Conversation
7f28e85
to
fb06c07
Compare
Looks like caches are still working, plus the tests in godotengine/godot-cpp-template#70 have succeeded (especially, the Android ones which I was unsure of). I'm taking this as a good sign that this PR retains cross compatibility! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this seems good to me! It's really just moving a small amount of stuff from the workflow into an action
e17cee9
to
090abe2
Compare
090abe2
to
9943675
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
As discussed in the godot-cpp meeting. This action is specifically intended to be used by dependants of godot-cpp, to set up godot-cpp in their own github workflows. A follow-up PR will use this github action in godot-cpp-template (edit: godotengine/godot-cpp-template#70).
There are quite a few differences to godot-cpp-template's setup steps. I don't know if they started the same but diverged later, or if godot-cpp-template has always made different decisions from godot-cpp itself. Here is godot-cpp-template's version for reference.
I based my implementation mostly on godot-cpp. Here are the key differences I see:
actions/setup-java@v4
andandroid-actions/setup-android@v3
are used on godot-cpp-template, whilenttld/setup-ndk@v1
is used on godot-cpp.godot-cpp-template
, while they are explicitly disabled ongodot-cpp
. This was recently decided in [Web] Don't cache emsdk #1639 and should not be reverted.build-essential pkg-config
on linux. godot-cpp only installs these dependencies for the cmake build. I conclude they may not be needed for scons builds.I think that's all of the differences, though the github runner shall smite my PR if it's not compatible anymore.