Fix stack smashing when Godot methods return char32_t, char16_t or wchar_t
#1753
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enetheru
approved these changes
Apr 1, 2025
|
Cherry-picked for 4.3 in PR #1803 |
|
Cherry-picked for 4.4 in PR #1805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1741
It looks like we were incorrectly encoding return values for functions that return
char32_t,char16_tandwchar_tas pointers to those exact types, whereas Godot is encoding them as pointers toint64_tThis PR fixes that!
In a follow up, we should update both SCons and cmake to use the
-fstack-protector-strongflag with GCC and the equivalent flag for all other compilers (at least in debug builds), so that we can catch these sort of issues quicker.