Skip to content

CMake: Match #1758 move of DEBUG_METHODS_ENABLED from build options to defs.hpp #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

CMake: Match #1758 move of DEBUG_METHODS_ENABLED from build options to defs.hpp #1769

merged 1 commit into from
Apr 17, 2025

Conversation

@enetheru
Copy link
Collaborator

With PR #1758 the build options were changed to prevent re-definition warnings.

This brings the CMake back into parity.

@enetheru enetheru requested review from a team as code owners April 16, 2025 04:12
dsnopek
dsnopek approved these changes Apr 16, 2025
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I've approved, but this will need to be rebased to remove the sccache-action commit now that that is merged

@enetheru
Copy link
Collaborator Author

rebased

@dsnopek dsnopek added bug This has been identified as a bug cmake topic:buildsystem Related to the buildsystem or CI setup cherrypick:4.4 labels Apr 17, 2025
@dsnopek dsnopek added this to the 4.x milestone Apr 17, 2025
@dsnopek dsnopek merged commit 195188f into godotengine:master Apr 17, 2025
11 checks passed
@dsnopek
Copy link
Collaborator

dsnopek commented Jun 24, 2025

Cherry-picked for 4.4 in PR #1805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees

No one assigned

Labels

bug This has been identified as a bug cmake topic:buildsystem Related to the buildsystem or CI setup

Projects

None yet

Milestone

4.x

Development

Successfully merging this pull request may close these issues.

2 participants

@enetheru @dsnopek