Use LocalVector instead of std::vector #1841
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes (almost) all of the std::vector usage and replaces it with Godot's LocalVector.
There is still one place in
classes/wrapped.cpp
where std::vector is still used that I didn't want to mess with because it calls push_back during static initialization and the allocation function that LocalVector::push_back uses from the GDExtension API isn't registered yet. Reworking this to figure out a better time to call push_back didn't look too fun so I'm just going to leave it as is.I tested the build time difference with ClangBuildAnalyzer and got these results:
With these changes:
Executed in 103.10 secs
**** Time summary:
Compilation (1025 times):
Parsing (frontend): 1640.2 s
Codegen & opts (backend): 190.6 s
Without these changes
Executed in 106.30 secs
**** Time summary:
Compilation (1025 times):
Parsing (frontend): 1682.0 s
Codegen & opts (backend): 184.8 s