[SCons] Move toolchains logic to tools folder, various improvements. #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
5 tasks
Faless
force-pushed
the
build/4.x_scons_tools
branch
3 times, most recently
from
50a187b
to
813bad3
Compare
Faless
force-pushed
the
build/4.x_scons_tools
branch
from
813bad3
to
7826dd3
Compare
akien-mga
reviewed
Jun 27, 2022
SConstruct
Outdated
Comment on lines
20
to
21
| elif sys.platform.startswith("freebsd"): | ||
| host_platform = "freebsd" | ||
| default_platform = "freebsd" |
There was a problem hiding this comment.
Should probably be removed as removed further down.
akien-mga
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
Looks good to me, just a couple improvements to do as we discussed on chat (sync Android with godotengine/godot#61691).
Faless
force-pushed
the
build/4.x_scons_tools
branch
from
7826dd3
to
7850785
Compare
|
Should be good to go once CI passes, note that I have another branch with an extra commit that also refactor "arch" inside the platform tools and move the global options to a |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
testgdextension file missing windows 32 bits.osxandios.