Fix incorrect length passed to CharString
#961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
CharString-producing methods ofStringto pass the correct length, which should be the size without null-terminator included, to line up with whatString::length()returns.This PR also addresses a (harmless) bug of these functions passing size with null-terminator included to
string_to_*_charswhen it should have been passing size without null-terminator included, since it ends up getting clamped anyway, as seen here.I commented about this in #633, but I figured this leans more towards being a bug, so I decided to make a PR for it, so it doesn't fall through the cracks.
This behavior also lines up with how
String/CharStringbehaves in the engine itself.