Add a normal map test in the 2D lights and shadows demo #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was requested by lawnjelly so we can test whether normal map orientation behaves as expected.
aaronfranke
reviewed
Aug 18, 2020
| @@ -186,11 +258,13 @@ occluder = SubResource( 1 ) | |||
| position = Vector2( 159.289, 452.441 ) | |||
| texture = ExtResource( 3 ) | |||
| color = Color( 1, 0.446392, 0.0576646, 1 ) | |||
| energy = 0.95 | |||
There was a problem hiding this comment.
I dimmed the lights to 95% in #414 to try and make the demo look similar to when it was using GLES 3. Is this tweak no longer necessary?
There was a problem hiding this comment.
Probably not, but I find that the demo looked a bit dark otherwise. (It made the normal mapping more difficult to notice.)
aaronfranke
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was requested by lawnjelly so we can test whether normal map orientation behaves as expected.
The normal map was generated using Laigter (with the Y axis inverted).
Preview
With batching (broken)
Notice how all sprites but the top-left one have incorrect normal mapping. The Godot logo should appear as a "bump", not a "hole".
Without batching (correct)