Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an 'unsupported on android' warning to 2d skeleton documentation #3989

Merged
merged 2 commits into from
Sep 26, 2020

Conversation

kjav
Copy link
Contributor

@kjav kjav commented Sep 10, 2020

No description provided.

@Calinou
Copy link
Member

Calinou commented Sep 10, 2020

I'd make the disclaimer more precise and mention HTML5 as well. 2D skeletons should work on Android when using the GLES3 renderer. See godotengine/godot#41927.

@kjav
Copy link
Contributor Author

kjav commented Sep 10, 2020

Hi @Calinou - good point, I'll add in something about HTML5. However the GLES3 renderer is also broken in a different way; the issue here explains that there can be colour problems with it godotengine/godot#35772 (comment)

@kjav kjav closed this Sep 10, 2020
@Calinou
Copy link
Member

Calinou commented Sep 10, 2020

You can amend your pull request instead of opening a new one 🙂

@kjav
Copy link
Contributor Author

kjav commented Sep 10, 2020

@Calinou Thanks - I was going to close this one as it seems you covered it in that other issue you opened (godotengine/godot#41927) - unless that one is just in the editor and not in the docs?

@Calinou
Copy link
Member

Calinou commented Sep 10, 2020

@kjav That PR is only for the class reference, not the documentation page.

@kjav
Copy link
Contributor Author

kjav commented Sep 11, 2020

Thanks Calinou, I didn't realise that. I'll update the message

@kjav kjav reopened this Sep 11, 2020
@NathanLovato
Copy link
Contributor

I took the liberty to edit the message directly to save you some time.

@NathanLovato NathanLovato merged commit 22c6fdb into godotengine:master Sep 26, 2020
@NathanLovato
Copy link
Contributor

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants