Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document addition of METALLIC to light() built-ins (pending #42548) #4198

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

pezcode
Copy link
Contributor

@pezcode pezcode commented Oct 4, 2020

This PR adds changes required after godotengine/godot#42548. See godotengine/godot-proposals#1604 for more info.

@pezcode pezcode changed the title Document addition of METALLIC to light() built-ins (pending https://github.com/godotengine/godot/pull/42548) Document addition of METALLIC to light() built-ins (pending #42548) Oct 4, 2020
@NathanLovato
Copy link
Contributor

Could you please ping me to merge it once the PR on the godot repository got merged? I'll merge it then.

@akien-mga
Copy link
Member

The godot PR is merged, this one needs to be rebased since the relevant page was moved.

@pezcode
Copy link
Contributor Author

pezcode commented Oct 9, 2020

@NathanLovato Rebased on top of master and ready to merge.

@NathanLovato NathanLovato merged commit 62a8acf into godotengine:master Oct 9, 2020
@NathanLovato
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants