Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scene unique nodes: clarify intended usage #6670

Merged
merged 6 commits into from
Feb 24, 2023
Merged

Scene unique nodes: clarify intended usage #6670

merged 6 commits into from
Feb 24, 2023

Conversation

31
Copy link
Contributor

@31 31 commented Jan 25, 2023 •
edited
Loading

Update scene unique nodes doc to clarify what it is meant for, what it can't do, and some alternatives.

I wasn't able to find much official info about this feature other than the implementation PR and a couple release notes articles. I think it's worth bringing it into the actual docs:

I also made some subjective edits that remove some ambiguity and I think make the doc read more naturally.

Bugsquad edit:

@Calinou Calinou added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Jan 25, 2023
@31 31 force-pushed the dev/31/sceneunique branch from 59b2ca1 to 1a18dc7 Compare January 28, 2023 19:42
YuriSizov
YuriSizov suggested changes Jan 28, 2023
View reviewed changes
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall direction is good, but I have a few suggestions and some formatting corrections.

31 and others added 4 commits January 28, 2023 15:29
@31 @YuriSizov
Apply suggestions from code review
d588e3a 
Co-authored-by: Yuri Sizov <11782833+YuriSizov@users.noreply.github.com>
@31
Feedback changes
91a70d7 
Apply suggestions.

Rework intro.

Remove some elaboration on same-scene behavior.

Remove Groups example.
@31
Update "Access as Unique Name" screenshot and text
09ebd47
@31
Merge remote-tracking branch 'godotengine/master' into dev/31/sceneun…
01fba52 
…ique
@31 31 requested a review from YuriSizov January 29, 2023 08:00
@raulsntos raulsntos mentioned this pull request Jan 30, 2023
Closed
@dalexeev dalexeev mentioned this pull request Feb 20, 2023
Closed
@YuriSizov YuriSizov merged commit a9ed49e into godotengine:master Feb 24, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@31 31 deleted the dev/31/sceneunique branch February 25, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C# Error with Unique Node - returns always null
3 participants
@31 @YuriSizov @Calinou