Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCU (single compilation unit) build docs #7478

Merged
merged 1 commit into from
Jun 8, 2023
Merged

SCU (single compilation unit) build docs #7478

merged 1 commit into from
Jun 8, 2023

Conversation

lawnjelly
Copy link
Member

@lawnjelly lawnjelly commented Jun 6, 2023 •
edited
Loading

Add info to the buildsystem docs.

Short docs for #77170

Notes

  • It is possible we could write more, but this is enough to get started for contributors.
  • Could possibly be one higher level of "titling" for the title, not sure though.

@YuriSizov YuriSizov added the area:contributing Issues and PRs related to the Contributing/Development section of the documentation label Jun 6, 2023
@mhilbrunner mhilbrunner added this to the 4.1 milestone Jun 7, 2023
akien-mga
akien-mga approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you wrap the lines at 80 chars like in the rest of the document?
(For the .. note:: you'd continue lines at the same column as the first word.)

@akien-mga
Copy link
Member

Should likely be updated to match godotengine/godot#77976 before merging.

@lawnjelly
SCU (single compilation unit) build docs
a2fd3fd 
Add info to the buildsystem docs.
@lawnjelly
Copy link
Member Author

Should likely be updated to match godotengine/godot#77976 before merging.

Done. Should be checked again as I had to simplify the text slightly due to the single option.

@akien-mga akien-mga merged commit cfaa7c7 into godotengine:master Jun 8, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation enhancement topic:buildsystem
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@lawnjelly @akien-mga @mhilbrunner @YuriSizov