-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#: Document new version defines and remove mentions of old defines #7525
Conversation
I wonder why some platforms have multiple defines, probably a leftover from an older version. For example, the Web platform used to be called JavaScript1, and since Godot adds OS features for each platform it's likely that C# was just emulating this by adding the Also, at some point there was a I guess the situation with ( We could probably remove the duplicate defines, although I guess it breaks compatibility. But I agree that we should only mention the could mention only one in the documentation so I'd pick the ones that match the platform name. Footnotes |
0687475
to
17cd80d
Compare
Ok, I removed the old apple platform defines and used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
17cd80d
to
31ac1bc
Compare
Thank you! Merged. And thanks Raul for reviewing :) |
The version defines were added in godotengine/godot#78249 and godotengine/godot#78270
The feature defines haven't existed in a long time, and even if godotengine/godot#53920 finally gets anywhere, they will be in a different format, The architecture defines no longer exist either and there doesn't seem to be any plan / demand to reintroduce them.
For the platforms that have multiple defines we should probably just pick one to mention, but I am not sure which of them is preferred.