Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to parts 6 and 7 of the 2D tutorial #7923

Closed
wants to merge 1 commit into from
Closed

Updates to parts 6 and 7 of the 2D tutorial #7923

wants to merge 1 commit into from

Conversation

GarrickWinter
Copy link
Contributor

In the HUD section, X=200 isn't a valid size for the button. If 200 is entered as directed, the size automatically updates to 370. Given the described aim of this change, I suspect 400 was the intended value, and 400 does produce the described result (some padding between the text and the border of the button).

Also adding differentiation between GDScript and C# around the audio scripting in part 7.

@Piralein
Copy link
Member

Piralein commented Sep 16, 2023 •
edited
Loading

If 200 is entered as directed, the size automatically updates to 370.

How are your Font settings defined? If I create a Button with the Xolonium-Regular.ttf and 64px font size, it's width with the word Start in it is 177px. Maybe your text contains some whitespaces.

Updating the size to 400 would stretch the Button to nearly the whole screen width.
button

@Piralein Piralein added enhancement area:getting started Issues and PRs related to the Getting Started section of the documentation labels Sep 16, 2023
@GarrickWinter
Copy link
Contributor Author

Ah, my bad. The font settings are correct, but I had confused the actual text to be entered, so the size was different. I'll remove that change!

skyace65
skyace65 approved these changes Sep 23, 2023
View reviewed changes
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@AThousandShips
Copy link
Member

Could you please squash your commits

@raulsntos raulsntos mentioned this pull request Sep 23, 2023
Merged
@raulsntos raulsntos linked an issue Sep 23, 2023 that may be closed by this pull request
CS code missing for adding music #8003
Closed
@GarrickWinter @raulsntos @AThousandShips
Update 06.heads_up_display.rst
3d4dbd0 
Adding differentiation between GDScript and C# around the audio scripting.

Co-Authored-By: Raul Santos <raulsntos@gmail.com>
Co-Authored-By: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
@GarrickWinter
Copy link
Contributor Author

Commits squashed!

@mhilbrunner
Copy link
Member

We just merged #8017, which fixes the same spots. Unfortunate that we got 2 PRs for the same thing in this case, sorry :) I still want to thank you for contributing, and for following up with feedback so quickly, squashing commits etc. Great work! 🎉

@mhilbrunner mhilbrunner closed this Oct 6, 2023
@mhilbrunner mhilbrunner added archived and removed enhancement area:getting started Issues and PRs related to the Getting Started section of the documentation labels Oct 6, 2023
@GarrickWinter
Copy link
Contributor Author

Sounds great! Glad lots of eyes were on it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos left review comments

@AThousandShips AThousandShips AThousandShips left review comments

@skyace65 skyace65 skyace65 approved these changes

Assignees
No one assigned
Labels
archived
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CS code missing for adding music
6 participants
@GarrickWinter @Piralein @AThousandShips @mhilbrunner @raulsntos @skyace65