-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for compiling with Direct3D 12 support on Windows #8610
Merged
mhilbrunner
merged 2 commits into
godotengine:master
from
clayjohn:D3D12-compile-instructions
Dec 13, 2023
Merged
Add instructions for compiling with Direct3D 12 support on Windows #8610
mhilbrunner
merged 2 commits into
godotengine:master
from
clayjohn:D3D12-compile-instructions
Dec 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
added
enhancement
area:contributing
Issues and PRs related to the Contributing/Development section of the documentation
topic:buildsystem
labels
Dec 12, 2023
akien-mga
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
akien-mga
reviewed
Dec 12, 2023
akien-mga
reviewed
Dec 12, 2023
akien-mga
reviewed
Dec 12, 2023
akien-mga
reviewed
Dec 12, 2023
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
clayjohn
force-pushed
the
D3D12-compile-instructions
branch
from
December 12, 2023 21:46
bf92283
to
671a844
Compare
Thanks for the comments! Should be ready to go now |
RandomShaper
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
mhilbrunner
approved these changes
Dec 13, 2023
Thank you! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:contributing
Issues and PRs related to the Contributing/Development section of the documentation
enhancement
topic:buildsystem
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation instructions to accompany godotengine/godot#70315
Mostly just pulled from the PR's description and cleaned up