Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C# examples to Using Viewports documentation #9804

Merged

Conversation

ShawnHardern
Copy link
Contributor

Add C# examples to Using Viewports documentation

@skyace65 skyace65 added enhancement topic:dotnet area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Aug 22, 2024
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to the .NET documentation!

tutorials/rendering/viewports.rst Outdated Show resolved Hide resolved
tutorials/rendering/viewports.rst Outdated Show resolved Hide resolved
tutorials/rendering/viewports.rst Outdated Show resolved Hide resolved
@ShawnHardern
Copy link
Contributor Author

Thanks for contributing to the .NET documentation!

Hey @raulsntos thanks for giving this a look over😁! I tried my best to full in the missing gaps with what worked in my godot + IDE combo, will make the suggested changes😎

Co-authored-by: Raul Santos <raulsntos@gmail.com>
Copy link
Member

@raulsntos raulsntos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@skyace65 skyace65 merged commit 88d2383 into godotengine:master Aug 23, 2024
1 check passed
@skyace65
Copy link
Contributor

Thanks!

@ShawnHardern ShawnHardern deleted the update-viewports-examples-csharp branch August 24, 2024 00:21
@mhilbrunner
Copy link
Member

Cherry-picked to 4.3 in #10038.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants