Skip to content

Commit

Permalink
Stop progress_cb from generating spurious warnings (#243)
Browse files Browse the repository at this point in the history
`progress_cb` is used to give progress updates on pushes and pulls. There is
no reason for it to pollute the logs by logging its updates as warnings.
Changed these to plain print statements.
  • Loading branch information
TV4Fun committed Jul 7, 2024
1 parent f6002fa commit e86106b
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions godot-git-plugin/src/git_callbacks.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,7 @@
extern "C" int progress_cb(const char *str, int len, void *data) {
(void)data;

char *progress_str = new char[len + 1];
std::memcpy(progress_str, str, len);
progress_str[len] = '\0';
godot::UtilityFunctions::push_warning("remote: ", godot::String::utf8(progress_str).strip_edges());
delete[] progress_str;
godot::UtilityFunctions::print("remote: ", godot::String::utf8(str, len).strip_edges());

return 0;
}
Expand Down Expand Up @@ -63,7 +59,7 @@ extern "C" int push_transfer_progress_cb(unsigned int current, unsigned int tota
progress = (current * 100) / total;
}

godot::UtilityFunctions::print("Writing Objects: ", uint32_t(progress), "% (", uint32_t(current), "/", uint32_t(total), ", ", uint32_t(bytes), " bytes done.");
godot::UtilityFunctions::print("Writing Objects: ", uint32_t(progress), "% (", uint32_t(current), "/", uint32_t(total), ", ", uint32_t(bytes), " bytes done.)");
return 0;
}

Expand Down

0 comments on commit e86106b

Please sign in to comment.