Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating projects in non-empty folders with a confirmation popup #1811

Closed
aaronfranke opened this issue Nov 12, 2020 · 1 comment · Fixed by godotengine/godot#42526
Closed
Milestone

Comments

@aaronfranke
Copy link
Member

aaronfranke commented Nov 12, 2020

Follow-up to godotengine/godot#15835, the linked PR replaces godotengine/godot#39220.

Describe the project you are working on: New ones.

Describe the problem or limitation you are having in your project:

Creating projects in non-empty folders can be a dangerous operation, but is sometimes desired, especially by @SubSage. The specific use case here is that if you create an empty repository on GitHub, then clone to your computer, the cloned repo contains a .git folder, so you can't create a project there, and have to perform the workaround at the bottom of this proposal.

Describe the feature / enhancement and how it helps to overcome the problem or limitation:

The enhancement is to allow creating projects in non-empty folders with a warning and a confirmation popup, rather than prevent users from doing this completely.

Describe how your proposal will work, with code, pseudocode, mockups, and/or diagrams:

Branch: https://github.com/aaronfranke/godot/tree/project-in-non-empty

PR: godotengine/godot#42526

The PR changes the message from an error to a warning, and adds a confirmation dialog that looks like the below (I moved the windows so that you can see everything at once, but normally they appear on top of each other).

Screenshot from 2020-11-12 21-28-38

If this enhancement will not be used often, can it be worked around with a few lines of script?:

It can be worked around by creating the project elsewhere, then closing Godot, then copying the files to the desired location, then opening Godot and browsing to the new location.

Is there a reason why this should be core and not an add-on in the asset library?:

This is about the project manager, so it can't be an add-on in the asset library.

@Zireael07
Copy link

Just dropping by to say that Sage isn't the only one who would like this 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants