Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename get_ok() and get_cancel() to get_ok_button() and get_cancel_button() #2418

Closed
me2beats opened this issue Mar 7, 2021 · 1 comment
Closed

Comments

@me2beats
Copy link

me2beats commented Mar 7, 2021

Describe the project you are working on

plugins

Describe the problem or limitation you are having in your project

there's get_ok() in AcceptDialog
there's get_cancel() ConfirmationDialog
there's get_close_button() in AcceptDialog.
That sounds inconsistent.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Renaming some of this methods would make API more consistent (in terms of naming).

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

There are two options:

  1. Rename get_close_button() to get_close()
  2. Rename get_ok() and get_cancel() to get_ok_button() and get_cancel_button()

I prefer (2), this makes the names of these methods clearer.

If this enhancement will not be used often, can it be worked around with a few lines of script?

Is there a reason why this should be core and not an add-on in the asset library?

@YuriSizov
Copy link
Contributor

This was already tracked in godotengine/godot#16863 and implemented for master in godotengine/godot#44389.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants