Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display node's properties in the Inspector when in Code Editor #247

Closed
rezgi opened this issue Nov 21, 2019 · 9 comments
Closed

Display node's properties in the Inspector when in Code Editor #247

rezgi opened this issue Nov 21, 2019 · 9 comments
Milestone

Comments

@rezgi
Copy link

rezgi commented Nov 21, 2019

Describe the project you are working on:
Creating a custom node with exported variables.

Describe the problem or limitation you are having in your project:
We always need to toggle between the 2D (or 3D) view to check on the exported variables or modify them when coding. When we are in code editor, we only have access to the script's inspector properties, it would be nice to have the 2D/3D view properties at the same time as the script's parameters.

Describe how this feature / enhancement will help you overcome this problem or limitation:
It's more of a time-saving and UX feature, as we would avoid constantly toggling between the 2 displays and keep losing focus on the code when programming.

Show a mock up screenshots/video or a flow diagram explaining how your proposal will work:
We would have this :
01

Instead of this :
02

Describe implementation detail for your proposal (in code), if possible:
Well don't know about C++, but I guess it's just about telling the engine to display the node's 2D/3D view by only adding the script's parameters on top or bottom when the user is in the code editor.

If this enhancement will not be used often, can it be worked around with a few lines of script?:
Nope, it's about the engine GUI. The only workaround is to toggle with shortcuts or mouse, which makes us lose focus of the code.

Is there a reason why this should be core and not an add-on in the asset library?:
It's about UX improvement that would benefit all users and it's a heavy change, or maybe we could debate about how it makes the editor less focused ?

@Calinou
Copy link
Member

Calinou commented Nov 21, 2019

Does this mean the editor should no longer switch from the Script view to the 2D/3D view when selecting a node in the scene tree dock?

@KoBeWi
Copy link
Member

KoBeWi commented Nov 22, 2019

Does this mean the editor should no longer switch from the Script view to the 2D/3D view when selecting a node in the scene tree dock?

Related to godotengine/godot#33704
Maybe the view switch should be changed to double click when in Script Editor.

@golddotasksquestions
Copy link

Why not just stack the script properties at the bottom of the node properties and always show both as soon as a node has a script?

stackproperties

@rezgi
Copy link
Author

rezgi commented Nov 22, 2019

@Calinou No, it's exactly as @golddotasksquestions showed : keep showing the node's inspector properties when it has a script and add the script's properties to it.

@wyattbiker
Copy link

Just as a note for consideration, a script can be attached to many nodes. So how would that work?

@rezgi
Copy link
Author

rezgi commented Dec 3, 2019

@wyattbiker Since the script's properties can be stacked with the node's properties, it shouldn't make any problem no ?

@wyattbiker
Copy link

Would be nice if the script button (blue circled) opened up but kept the node inspector open.

The indirect way is to select a node with an attached script and click on the Script tab (red circled). That opens up a script window, but notice how now the node inspector stays intact. You can select any script and the node's inspector window stays intact including exported variables. Would be nice if this happened when the node's script attachment button did the same.
image

@Calinou
Copy link
Member

Calinou commented Jun 9, 2023

In both 3.5 and 4.0, selecting nodes in the script editor no longer switches the visible main screen. @wyattbiker's suggestion is still relevant though.

@akien-mga
Copy link
Member

Implemented by godotengine/godot#84284.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants