Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning for boolean comparison expressions #128

Closed
SolarLune opened this issue Dec 11, 2019 · 3 comments
Closed

Warning for boolean comparison expressions #128

SolarLune opened this issue Dec 11, 2019 · 3 comments
Labels

Comments

@SolarLune
Copy link

SolarLune commented Dec 11, 2019

The below line is warned, and the reason is: "Unhandled comparation expression contains".

print(a == true)

This is valid GDScript, so the warning shouldn't be there, right? Also, it seems like the warning message itself is incomplete, and that it's supposed to be "comparison", not "comparation", so it might also need to be re-examined and spell-checked.

EDIT: Seems to be the same issue as #66. The real problem here is that this is happening on my custom functions, so the solution isn't to just patch print() either, haha; it was just an example.

@SolarLune SolarLune changed the title Syntax highlights boolean comparison expressions Warning for boolean comparison expressions Dec 11, 2019
@Calinou Calinou added the bug label Dec 11, 2019
@DaelonSuzuka
Copy link
Collaborator

DaelonSuzuka commented Feb 28, 2024

Closing because this was never an issue with the extension: errors come from the language server running in the Godot Editor.

Also, the language server has improved significantly in recent versions. I doubt this error happens anymore.

@SolarLune
Copy link
Author

Closing because this was never an issue with the extension: errors come from the language server running in the Godot Editor.

Also, the language server has improved significantly in recent versions. I doubt this error happens anymore.

Sounds good - did you mean to close this?

@DaelonSuzuka
Copy link
Collaborator

Must have hit the wrong button, thanks for catching that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants