Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"godot-tools.check_status" inconsistency in package.json #240

Closed
pcting opened this issue Oct 22, 2020 · 2 comments · Fixed by #246
Closed

"godot-tools.check_status" inconsistency in package.json #240

pcting opened this issue Oct 22, 2020 · 2 comments · Fixed by #246
Labels

Comments

@pcting
Copy link

pcting commented Oct 22, 2020

"godot-tools.check_status" should be "godot_tools.check_status"

"godot-tools.check_status": {

@linkpy
Copy link
Contributor

linkpy commented Oct 27, 2020

That option wasn't used at all before, as in, it has no impact and wasn't even looked for before.
I don't know what is its initial intended behaviour. I think it's just to hide the indicator at the bottom right of the editor, since disabling the status check is not possible.

If you know the original intent of that option please let me know. In the mean time i opened a PR to remove that option.

@pcting
Copy link
Author

pcting commented Oct 27, 2020

I'd remove it then; I only noticed the inconsistency when I was working on my other PR

Calinou pushed a commit that referenced this issue Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants