Fix conditional breakpoints being parsed as regular breakpoints #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Jun 17, 2021
Heyter
added a commit
to Heyter/godot-vscode-plugin
that referenced
this pull request
Aug 19, 2021
|
The issue this fixes affects my workflow. Thank you for your work on this. Is there anything preventing this from being merged? |
|
@Geequlim Should we tag 1.1.3 to be released on the Visual Studio Marketplace? |
|
That would be lovely. Thank you for merging this! |
|
I remember you have permission to publish.
Hugo Locurcio ***@***.***>于2021年11月3日 周三22:16写道：
… @Geequlim <https://github.com/Geequlim> Should we tag 1.1.3 to be
released on the Visual Studio Marketplace?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#278 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVEKTFSA4RSURAUEO2TFBTUKE73ZANCNFSM464CTI6A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite
supportsConditionalBreakpointsbeing set tofalse, seems the debug adapter still expects the debugger to explicitly filter out conditional breakpoints, or continue treating them as regular breakpoints (which makes the presence ofsupportsConditionalBReakpointkind of pointless? I dunno.)Until Godot supports conditional breakpoints, I'm opting to just remove them entirely as there's no feasible way of hooking into the debugger so there's no confusion. Now they'll be ignored.
Fixes #267