Fix "Continue" for multiple breakpoints in the same script #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting a new debug session `this.project_path` is still undefined. Trying to pass that into `path.relative()` will cause a type error. Therefore the setBreakPointsRequest will fail after the first breakpoint. That's why it will only process the first breakpoint of a file.
Calinou
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #296
When starting a new debug session a
setBreakPointsRequest()is triggered for each file that contains breakpoints.However at that time
this.project_pathis still undefined. It will only be initialized during thelaunchRequest().Trying to pass
undefinedintopath.relative()will cause a type error which means thesetBreakPointsRequest()will fail and exit after the first breakpoint of each file.With this fix we skip the respective lines during initialization.
At that time the
project_pathis still unknown so we can't construct the relative path.Also the Mediator isn't connected yet, so these lines wouldn't do anything anyway.