New footer design #907
Merged
New footer design #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coppolaemilio
added
enhancement
topic:theme
Calinou
reviewed
Aug 18, 2024
Calinou
reviewed
Aug 18, 2024
Calinou
reviewed
Aug 18, 2024
Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new footer design was overdue. The current issues with the current one are: there is little contrast between the text and the background, and the columns are already full, so adding or removing links impact the styling of the site.
While the new design might be a bit taller, since this element lives always at the end of the page, it doesn't impact the existing content. The new design solves our issues of adding new links or columns when needed. It also provides a better organization of the existing links by creating a new category.
Old footer
New footer
This PR also updates the social media images including them as svgs in the footer code, decreasing the amount of requests needed to page every page. It also converts the main.css file into an scss file to prepare it for future updates like this one. Previously, all the code lived in a single file, but when we start rewriting some of them we can isolate them into their own files to make it easier to maintain.