Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download: Add Horizon OS APK and Horizon Store app, minor refactoring #936

Merged

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Sep 23, 2024

Edit: Removed that first change from the PR.
image

image

@akien-mga akien-mga added enhancement topic:content Issues and PRs related to static content labels Sep 23, 2024
@akien-mga
Copy link
Member Author

Actually looking at my first screenshot, I made a mistake as it's linking the Horizon Store app on the /download/android page which is for 4.3-stable (but we have 4.4-dev2 on Horizon Store).

I'll remove it for now, and we should remember to add it when we release 4.4-stable.

@akien-mga
Copy link
Member Author

Added a fix for that stray dot too:
image

tags:
- x86_32
- 32 bit
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the "32 bit" / "64 bit" tags, which don't say much in an age where most platforms are 64 bit and the relevant distinction is x86_64 or arm64.

- name: "linux.32"
title: "Linux"
caption: "Standard (x86_32)"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the "Standard" which didn't say anything useful. It's normally used to distinguish between "Standard" (no C#) and ".NET" (C#) builds, but the way this is designed, .NET builds were actually listed as "Standard - .NET" so all builds were "Standard".

@coppolaemilio coppolaemilio merged commit 2580c77 into godotengine:master Sep 23, 2024
1 check passed
@coppolaemilio
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement topic:content Issues and PRs related to static content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants