Skip to content

Commit

Permalink
C#: Let platforms signal if they support it or not
Browse files Browse the repository at this point in the history
Instead of hardcoding platform names that support C#, let platforms
set a flag indicating if they support it. All public platforms
except web already support it, and it's a pain to maintain a patch
for this list just to add additional names of proprietary console
platforms.

This makes adding new platforms or variants or existing platforms
much easier, as the platform can signal what it supports/doesn't
support directly, and we can avoid harcoding platform names.
  • Loading branch information
shana committed Feb 13, 2024
1 parent 3a8524d commit 21e524a
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 7 deletions.
10 changes: 3 additions & 7 deletions modules/mono/config.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
# Prior to .NET Core, we supported these: ["windows", "macos", "linuxbsd", "android", "web", "ios"]
# Eventually support for each them should be added back.
supported_platforms = ["windows", "macos", "linuxbsd", "android", "ios"]


def can_build(env, platform):
if env["arch"].startswith("rv"):
return False
Expand All @@ -14,9 +9,10 @@ def can_build(env, platform):


def configure(env):
platform = env["platform"]
# Check if the platform has marked mono as supported.
supported = env.get("supported", [])

if platform not in supported_platforms:
if not "mono" in supported:
raise RuntimeError("This module does not currently support building for this platform")

env.add_module_version_string("mono")
Expand Down
1 change: 1 addition & 0 deletions platform/android/detect.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ def get_flags():
return [
("arch", "arm64"), # Default for convenience.
("target", "template_debug"),
("supported", ["mono"]),
]


Expand Down
1 change: 1 addition & 0 deletions platform/ios/detect.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ def get_flags():
("arch", "arm64"), # Default for convenience.
("target", "template_debug"),
("use_volk", False),
("supported", ["mono"]),
]


Expand Down
1 change: 1 addition & 0 deletions platform/linuxbsd/detect.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ def get_doc_path():
def get_flags():
return [
("arch", detect_arch()),
("supported", ["mono"]),
]


Expand Down
1 change: 1 addition & 0 deletions platform/macos/detect.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ def get_flags():
return [
("arch", detect_arch()),
("use_volk", False),
("supported", ["mono"]),
]


Expand Down
1 change: 1 addition & 0 deletions platform/windows/detect.py
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ def get_flags():

return [
("arch", arch),
("supported", ["mono"]),
]


Expand Down

0 comments on commit 21e524a

Please sign in to comment.