Merge pull request #87459 from jsjtxietian/tween-from

Fix passing int to tween's `from` with float property will be forced to interpolate as int
godotengine · Jan 26, 2024 · 2a861ab · 2a861ab
2 parents 62c87dc + 3c59609
commit 2a861ab
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/scene/animation/tween.cpp b/scene/animation/tween.cpp
@@ -505,11 +505,13 @@ Tween::Tween(bool p_valid) {
 
 Ref<PropertyTweener> PropertyTweener::from(const Variant &p_value) {
 	ERR_FAIL_COND_V(tween.is_null(), nullptr);
-	if (!tween->_validate_type_match(p_value, final_val)) {
+
+	Variant from_value = p_value;
+	if (!tween->_validate_type_match(final_val, from_value)) {
 		return nullptr;
 	}
 
-	initial_val = p_value;
+	initial_val = from_value;
 	do_continue = false;
 	return this;
 }