[3.x] Don't warn about RETURN_VALUE_DISCARDED by default

godotengine · Aug 28, 2023 · 2b3d52a · 2b3d52a
1 parent 47e6467
commit 2b3d52a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/doc/classes/ProjectSettings.xml b/doc/classes/ProjectSettings.xml
@@ -362,7 +362,7 @@
  <member name="debug/gdscript/warnings/property_used_as_function" type="bool" setter="" getter="" default="true">
  If [code]true[/code], enables warnings when using a property as if it was a function.
  </member>
- <member name="debug/gdscript/warnings/return_value_discarded" type="bool" setter="" getter="" default="true">
+ <member name="debug/gdscript/warnings/return_value_discarded" type="bool" setter="" getter="" default="false">
  If [code]true[/code], enables warnings when calling a function without using its return value (by assigning it to a variable or using it as a function argument). Such return values are sometimes used to denote possible errors using the [enum Error] enum.
  </member>
  <member name="debug/gdscript/warnings/shadowed_variable" type="bool" setter="" getter="" default="true">

diff --git a/modules/gdscript/gdscript.cpp b/modules/gdscript/gdscript.cpp
@@ -2134,7 +2134,7 @@ GDScriptLanguage::GDScriptLanguage() {
  GLOBAL_DEF("debug/gdscript/completion/autocomplete_setters_and_getters", false);
  for (int i = 0; i < (int)GDScriptWarning::WARNING_MAX; i++) {
  String warning = GDScriptWarning::get_name_from_code((GDScriptWarning::Code)i).to_lower();
- bool default_enabled = !warning.begins_with("unsafe_") && i != GDScriptWarning::UNUSED_CLASS_VARIABLE;
+ bool default_enabled = !warning.begins_with("unsafe_") && i != GDScriptWarning::UNUSED_CLASS_VARIABLE && i != GDScriptWarning::RETURN_VALUE_DISCARDED;
  GLOBAL_DEF("debug/gdscript/warnings/" + warning, default_enabled);
  }
 #endif // DEBUG_ENABLED