Skip to content

Commit

Permalink
Merge pull request #89043 from Mickeon/autocomplete-EditorSettings
Browse files Browse the repository at this point in the history
Add autocompletion for EditorSettings' methods
  • Loading branch information
akien-mga committed Mar 1, 2024
2 parents 34effe4 + adbe238 commit 7c3090e
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 0 deletions.
29 changes: 29 additions & 0 deletions editor/editor_settings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1785,6 +1785,35 @@ void EditorSettings::notify_changes() {
root->propagate_notification(NOTIFICATION_EDITOR_SETTINGS_CHANGED);
}

#ifdef TOOLS_ENABLED
void EditorSettings::get_argument_options(const StringName &p_function, int p_idx, List<String> *r_options) const {
const String pf = p_function;
if (p_idx == 0) {
if (pf == "has_setting" || pf == "set_setting" || pf == "get_setting" || pf == "erase" ||
pf == "set_initial_value" || pf == "set_as_basic" || pf == "mark_setting_changed") {
for (const KeyValue<String, VariantContainer> &E : props) {
if (E.value.hide_from_editor) {
continue;
}

r_options->push_back(E.key.quote());
}
} else if (pf == "get_project_metadata" && project_metadata.is_valid()) {
List<String> sections;
project_metadata->get_sections(&sections);
for (const String &section : sections) {
r_options->push_back(section.quote());
}
} else if (pf == "set_builtin_action_override") {
for (const StringName &action : InputMap::get_singleton()->get_actions()) {
r_options->push_back(String(action).quote());
}
}
}
Object::get_argument_options(p_function, p_idx, r_options);
}
#endif

void EditorSettings::_bind_methods() {
ClassDB::bind_method(D_METHOD("has_setting", "name"), &EditorSettings::has_setting);
ClassDB::bind_method(D_METHOD("set_setting", "name", "value"), &EditorSettings::set_setting);
Expand Down
4 changes: 4 additions & 0 deletions editor/editor_settings.h
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,10 @@ class EditorSettings : public Resource {

void notify_changes();

#ifdef TOOLS_ENABLED
virtual void get_argument_options(const StringName &p_function, int p_idx, List<String> *r_options) const override;
#endif

EditorSettings();
~EditorSettings();
};
Expand Down

0 comments on commit 7c3090e

Please sign in to comment.