Skip to content

Commit

Permalink
Merge pull request #68717 from rune-scape/rune-compiler-regression
Browse files Browse the repository at this point in the history
Fixes #68716
  • Loading branch information
Chaosus authored Nov 16, 2022
2 parents 5993209 + 61df8f4 commit 95a85c9
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions modules/gdscript/gdscript_compiler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ GDScriptDataType GDScriptCompiler::_gdtype_from_datatype(const GDScriptParser::D

if (script.is_null()) {
_set_error(vformat(R"(Could not find class "%s" in "%s".)", p_datatype.class_type->fqcn, p_datatype.script_path), nullptr);
return GDScriptDataType();
} else {
// Only hold a strong reference if the owner of the element qualified with this type is not local, to avoid cyclic references (leaks).
// TODO: Might lead to use after free if script_type is a subclass and is used after its parent is freed.
Expand Down

0 comments on commit 95a85c9

Please sign in to comment.