Merge pull request #59002 from MythTitans/fix-visible-seam-torus

Fix normals computation at the 'seam' of smoothed torus shape
godotengine · Mar 11, 2022 · c291b48 · c291b48
2 parents 7866c98 + 8bcbaff
commit c291b48
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/modules/csg/csg_shape.cpp b/modules/csg/csg_shape.cpp
@@ -1530,6 +1530,9 @@ CSGBrush *CSGTorus3D::_build_brush() {
  for (int i = 0; i < sides; i++) {
  float inci = float(i) / sides;
  float inci_n = float((i + 1)) / sides;
+ if (i == sides - 1) {
+ inci_n = 0;
+ }
 
  float angi = inci * Math_TAU;
  float angi_n = inci_n * Math_TAU;
@@ -1540,6 +1543,9 @@ CSGBrush *CSGTorus3D::_build_brush() {
  for (int j = 0; j < ring_sides; j++) {
  float incj = float(j) / ring_sides;
  float incj_n = float((j + 1)) / ring_sides;
+ if (j == ring_sides - 1) {
+ incj_n = 0;
+ }
 
  float angj = incj * Math_TAU;
  float angj_n = incj_n * Math_TAU;