Skip to content

Commit

Permalink
Add determinant check for minimized windows
Browse files Browse the repository at this point in the history
When the Window is minimized, the transform-determinant can be 0.
Add a check to prevent this case.
  • Loading branch information
Sauermann committed Jul 21, 2023
1 parent 6588a4a commit e0bce0b
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion scene/main/viewport.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1347,7 +1347,12 @@ Vector2 Viewport::get_mouse_position() const {
// In this case get_screen_transform is not applicable, because it is ambiguous.
return gui.last_mouse_pos;
} else if (DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_MOUSE)) {
return get_screen_transform_internal(true).affine_inverse().xform(DisplayServer::get_singleton()->mouse_get_position());
Transform2D xform = get_screen_transform_internal(true);
if (xform.determinant() == 0) {
// Screen transform can be non-invertible when the Window is minimized.
return Vector2();
}
return xform.affine_inverse().xform(DisplayServer::get_singleton()->mouse_get_position());
} else {
// Fallback to Input for getting mouse position in case of emulated mouse.
return get_screen_transform_internal().affine_inverse().xform(Input::get_singleton()->get_mouse_position());
Expand Down

0 comments on commit e0bce0b

Please sign in to comment.