Merge pull request #84741 from lawnjelly/bogus_shader_log

[GLES3] Protect against bogus `glGetShaderInfoLog` return values.
godotengine · Nov 12, 2023 · ef2cc1c · ef2cc1c
2 parents 747bff0 + 593cdf0
commit ef2cc1c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/drivers/gles3/shader_gles3.cpp b/drivers/gles3/shader_gles3.cpp
@@ -328,7 +328,7 @@ void ShaderGLES3::_compile_specialization(Version::Specialization &spec, uint32_
  }
 
  char *ilogmem = (char *)Memory::alloc_static(iloglen + 1);
- ilogmem[iloglen] = '\0';
+ memset(ilogmem, 0, iloglen + 1);
  glGetShaderInfoLog(spec.vert_id, iloglen, &iloglen, ilogmem);
 
  String err_string = name + ": Vertex shader compilation failed:\n";
@@ -376,7 +376,7 @@ void ShaderGLES3::_compile_specialization(Version::Specialization &spec, uint32_
  }
 
  char *ilogmem = (char *)Memory::alloc_static(iloglen + 1);
- ilogmem[iloglen] = '\0';
+ memset(ilogmem, 0, iloglen + 1);
  glGetShaderInfoLog(spec.frag_id, iloglen, &iloglen, ilogmem);
 
  String err_string = name + ": Fragment shader compilation failed:\n";