RayTrace is much darker than ConeTrace with BakedLightmap

[seadra]

Godot version:
37aab45

OS/device including version:
Debian GNU/Linux

Issue description:
Using the same setting, by just changing the Mode between ConeTrace and RayTrace, the light energy is vastly different.

With ConeTrace

With RayTrace

Steps to reproduce:
Import a GLTF scene with Gen Lightmaps on. Add a DirectionalLight and add an WorldEnvironment with no light. Add a BakedLightmap and bake with ConeTrace. Then switch to RayTrace and rebake.

Minimal reproduction project:

• I searched the existing GitHub issues for potential duplicates.

[seadra]

Also, this is a different issue but some light leaks a little around the edge where the wall meets the floor in both modes (can be seen in both screenshots I attached above).

[reduz]

Conetrace is an approximation, and generally does look lighter. Raytrace is more correct. There will always be bias in very thin walls due to using an octree instead of a bvh.

…

On Dec 25, 2017 8:17 PM, "seadra" ***@***.***> wrote: Also, this is a different issue but some light leaks a little around the edge where the wall meets the floor in both modes (can be seen in both screenshots I attached above). — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#15055 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF-Z2wMhObIIefDa3DLN7T_jDrWpgsRwks5tECzxgaJpZM4RMaVD> .

[seadra]

Conetrace is an approximation, and generally does look lighter. Raytrace is
more correct.

That's a bit confusing but OK. It would be better to explicitly document this behavior because the difference is very dramatic, and the current documentation here doesn't mention it at all.

There will always be bias in very thin walls due to using an octree instead
of a bvh.

Unreal actually has a few parameters to mitigate the problem of light bleeding through thin-walls. Will there be similar options in Godot?

[reduz]

Will eventually port the bakers to OpenCL and use BVH or something else. This is the best that could be done in the little amount of time available to implememt the feature.

…

On Dec 25, 2017 9:59 PM, "seadra" ***@***.***> wrote: Conetrace is an approximation, and generally does look lighter. Raytrace is more correct. That's a bit confusing but OK. It would be better to explicitly document this behavior because the difference is very dramatic, and the current documentation here <http://docs.godotengine.org/en/latest/learning/features/3d/baked_lightmaps.html#baking-quality> doesn't mention it at all. There will always be bias in very thin walls due to using an octree instead of a bvh. Unreal actually has a few parameters to mitigate the problem of light bleeding through thin-walls. Will there be similar options in Godot? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#15055 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF-Z27AOcCGerOskjfFxjhVNE-yFQAh1ks5tEETcgaJpZM4RMaVD> .

[seadra]

Got it, looking forward to it!

[akien-mga]

We have now entered release freeze for Godot 3.0 and want to focus only on release critical issues for that milestone. Therefore, we're moving this issue to the 3.1 milestone, though a fix may be made available for a 3.0.x maintenance release after it has been tested in the master branch during 3.1 development. If you consider that this issue is critical enough to warrant blocking the 3.0 release until fixed, please comment so that we can assess it more in-depth.

[akien-mga]

Is this still relevant in the current master branch? If so, what should be done? Just mention this in the documentation?

[seadra]

Yes, it is, unfortunately, and this is bad UX IMO.
Can't Godot be changed such that they look similar out-of-the-box?

[Calinou]

@seadra I suppose it could be tweaked if we had several test scenes to compare each mode (with various lighting intensities). If we aim to make them look similar out of the box, it should work in the most situations possible 🙂

[Perrottacooking]

hi Seadra
v3.1.1 Stable - Still with the same problem?

[seadra]

Nothing changed as far as I can tell

[JFonS]

Closing as fixed by #44628.