Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command-line Mac OSX export inconsistent with GUI export #23073

Closed
lekoder opened this issue Oct 17, 2018 · 1 comment · Fixed by #34913
Closed

Command-line Mac OSX export inconsistent with GUI export #23073

lekoder opened this issue Oct 17, 2018 · 1 comment · Fixed by #34913
Assignees
@akien-mga
Labels
bug confirmed topic:editor
Milestone
3.2

Comments

@lekoder
Copy link
Contributor

lekoder commented Oct 17, 2018

Godot version:
3.1.alpha.custom_build.0dbe014

OS/device including version:
Windows 10

Issue description:
The OSX export is a .zip file containing the application. When exporting with command line with:

$GODOT --export "Mac OSX" $OUTDIR/game.zip $PROJECT

The resulting zip file is not the mac export, but just zipped source files.

Exporting with:

$GODOT --export "Mac OSX" $OUTDIR/game.app $PROJECT

Produces correct file, but with incorrect name (should be game.zip).

Steps to reproduce:

$GODOT --export "Mac OSX" $OUTDIR/game.zip $PROJECT

where GODOT is the Godot's binary and PROJECT is the path to project.godot

I understand that Godot decides on the format based on pkg or zip extension, and it misses the point with Mac export. I suggest adding explicit --export-format to the CLI interface.
@akien-mga akien-mga self-assigned this Oct 17, 2018
@akien-mga akien-mga added this to the 3.1 milestone Oct 17, 2018
@Calinou
Copy link
Member

Calinou commented Nov 14, 2018 •
edited
Loading

I can confirm this on commit c5656b7.

@akien-mga akien-mga modified the milestones: 3.1, 3.2 Jan 24, 2019
@akien-mga akien-mga mentioned this issue Jan 8, 2020
Merged
akien-mga added a commit to akien-mga/godot that referenced this issue Jan 8, 2020
@akien-mga
Export: Add dedicated --export-pack option to export data pack
7c29ce4 
The previous behavior relying on the provided extension was problematic
on macOS since .zip is the main extension used for the full project
export (binary + data pack).

We add a dedicated `--export-pack` command line option to define when
only the data pack should be exported. Its extension will still be
inferred from the path.

Fixes godotengine#23073.
@akien-mga akien-mga mentioned this issue Jan 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akien-mga akien-mga

Labels
bug confirmed topic:editor
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

Export: Add dedicated --export-pack option to export data pack akien-mga/godot
3 participants
@Calinou @lekoder @akien-mga