Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"!id_map.has(p_rid.get_data())" error with YSort populating during runtime #23889

Closed
TheFlamyy opened this issue Nov 21, 2018 · 1 comment · Fixed by #24164
Closed

"!id_map.has(p_rid.get_data())" error with YSort populating during runtime #23889

TheFlamyy opened this issue Nov 21, 2018 · 1 comment · Fixed by #24164
Assignees
Milestone

Comments

@TheFlamyy
Copy link
Contributor

Godot version: 03bd4d2

OS/device including version: Ubuntu

Issue description:
Creating and adding Node2Ds to a YSort after setting up the tree, will result in a spam in the debugger with the following error:

  <C Source>     ./core/rid.h:164 @ getornull()
  <Stack Trace>  Player.gd:31 @ _physics_process()

(The last line is just my debug script)

The following image should illustrate my issue/concern:
image

Steps to reproduce:
Create a new scene with YSort as the base node.
Include add_child(Node2D.new()) in any function which is called after the tree is initialized (e.g. not ready)
Look at the errors in the debugger.

@TheFlamyy TheFlamyy changed the title YSort-Debugspam "!id_map.has(p_rid.get_data())" error with YSort populating during runtime Nov 21, 2018
@akien-mga akien-mga added this to the 3.1 milestone Nov 21, 2018
@akien-mga akien-mga assigned akien-mga and bojidar-bg and unassigned akien-mga Nov 21, 2018
@bojidar-bg
Copy link
Contributor

Will look into it during the weekend (or a bit after it), sorry for the delay so far.

bojidar-bg added a commit to bojidar-bg/godot that referenced this issue Dec 4, 2018
If it weren't for this warning, it would have crashed in release builds.
Fix godotengine#23889, fixup 6b8d6e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants