Inspector can't show 3rd level of nesting for runtime dictionaries/arrays (fixed in master)

[hilfazer]

Godot version:

Godot_v3.1-beta2_win64

OS/device including version:

Windows 7 x64 SP1

Issue description:

When i try to expand doubly nested array or dictionary in Inspector it expands for a very brief time and then collapses. Sometimes it doesn't even expand at all.
Debugger expands just fine.

It happens only for runtime variables (from nodes in the Remote Scene). Thnx to pycbouh for spotting this.

Video:
https://www.dropbox.com/s/i07zsgpbpecqeie/GodotInspectorNestingCollapse.avi?dl=0

Steps to reproduce:
Place a breakpoint in _ready() function
Run the project
Try to fully expand "dict" variable in Inspector

Minimal reproduction project:

Dlownload link: https://downgit.github.io/#/home?url=https://github.com/hilfazer/Projects/tree/master/Godot/EngineIssues/InspectorDictionaryCollapse

Github location: https://github.com/hilfazer/Projects/tree/master/Godot/EngineIssues/InspectorDictionaryCollapse

[TicklesTheBrain]

Just wanted to confirm this is still happening on 3.1 stable on Windows 10. It also sometimes happens with 2nd level nesting as well, although it is way less severe: I'm always able to open it eventually, but ocasionally it requires clicking more than once.

[menip]

Can confirm this is an issue:

[hilfazer]

If only arrays are in play the bug doesn't surface

So it's all Dictionary's fault!

[akien-mga]

Still valid in the current master branch (8450658).

[DoubleCakes]

I'm having this problem too

Steam version 3.1.2

[YuriSizov]

So I've debugged it a bit and here's what happens.

First of all, the issue only appears in the Inspector for the remote debugger. Nested dictionaries fold and unfold without a problem when checking them in the editor without a running scene (values must be set manually or via a tool script).

Secondly, the issue has nothing to do with folding. The problem is that the inspector node for a dictionary property is perpetually updated. Which causes it to redraw on each frame and as a result folding to appear broken. Same does not happen with arrays. You can put a breakpoint into EditorPropertyArray::update_property(), and it will only trigger if you actually change something (this includes folding).

With EditorPropertyDictionary::update_property() the situation is different. It gets triggered constantly. If you go up the call stack you'll see that this is because on each frame there is a chain of signals that gets triggered informing the Inspector that the property has changed, when in fact nothing has changed.

Problem seems to sparkle from EditorDebuggerInspector::add_object. This check does not pass and the value is overridden, the changed set is updated, and signals are then emitted.

godot/editor/debugger/editor_debugger_inspector.cpp

Lines 186 to 189 in dee8f8d

	if (bool(Variant::evaluate(Variant::OP_NOT_EQUAL, debugObj->prop_values[pinfo.name], var))) {
	debugObj->prop_values[pinfo.name] = var;
	changed.insert(pinfo.name);
	}

While at the moment of the assignment the var variable contains a correct reference to the Dictionary in question, the debugObj->prop_values[pinfo.name] seems to always contain NULL. It looks like the value is destroyed somewhere after the assignment and thus the debug reference is constantly empty and requires to be updated while the value itself stays the same.

Any ideas where to look for that destruction?

[YuriSizov]

It turned out, I was reading the debugger wrong. The old value is still there, it just can't be properly compared to the new one.

Seems to be related to and possibly fixed by #29222 and #35816 (thanks @bojidar-bg).

[TicklesTheBrain]

Since #29222 is closed and #35816 is being debated, this issue is still in need of a temporary fix, especially something that could be applied to 3.2

[svendixon]

Any progress on this? I'm in 3.3.2 stable on Windows 10 and this still exists. The only work around I see, is to drop a breakpoint in the code and use the debugger just to see the nested dictionary... pretty annoying.

[Calinou]

Any progress on this? I'm in 3.3.2 stable on Windows 10 and this still exists. The only work around I see, is to drop a breakpoint in the code and use the debugger just to see the nested dictionary... pretty annoying.

As far as I know, nobody knows how to resolve this bug yet. It may have been fixed in the master branch for 4.0 though.

[YuriSizov]

I don't think that we have a way to compare dictionaries by value yet, even in master.

[MrOutsider]

Glad I found others have this problem. I independently replicated this bug.
I am on Godot v3.3.3.stable.official

[akien-mga]

Fixed by #35816.

[dalexeev]

Reproduced in 3.4.2. Looks like this fix hasn't been backported from master?

[Calinou]

Reproduced in 3.4.2. Looks like this fix hasn't been backported from master?

Reimplementing #35816 for 3.x would break compatibility with existing projects, not to mention there is no way to get the old behavior back: #35816 (comment)

[Calinou]

Reopening, as this still needs to be fixed in 3.x.

[akien-mga]

Well I don't think this will ever be fixed in 3.x, which is why I closed it as fixed in 4.0.
We can keep it open if users want but I wouldn't give false hopes, this is not easy to fix and probably not worth it for 3.x.

[akien-mga]

Fixed in 3.5 by #60737.