Export to Android fails with INSTALL_PARSE_FAILED_NO_CERTIFICATES if debug keystore unspecified

[nightblade9]

Godot version: 3.1

OS/device including version: Windows 8

Issue description: Running on Android fails. It should succeed (valid APK)

This is similar to #18222. When I run/export on Android, nothing happens. Exporting the APK file and then installing it via ADB shows this error: Failure [INSTALL_PARSE_FAILED_NO_CERTIFICATES: Failed to collect certificates from /data/app/vmdl1971499572.tmp/base.apk: Attempt to get length of null array]

The root cause? I didn't specify a debug key, or I didn't specify the correct user name and password. Specifying those, fixes the problem.

My ask: make the failure reason more clear to the user. (Especially for users without Android experience, it would be best to see the error in a Godot pop-up of some sort.)

[nightblade9]

Updated to be a UX "improvement" request now that I figured out the problem.

[LGLTeam]

I'm getting the same error when running my app though adb. How come?

[volzhs]

@akien-mga I think this is fixed by e3e5a1b

[akien-mga]

@volzhs I wonder as this commit was included in 3.1.stable against which this issue was opened, so it seems it's not sufficient.

OP says:

I didn't specify a debug key, or I didn't specify the correct user name and password. Specifying those, fixes the problem.

I think not specifying the debug key might indeed be prevented by e3e5a1b, but maybe it's still possible to export with a debug key and wrong username/password that would trigger this error.

[Patchcoat]

I've verified this bug occurs with a specified debug key and the wrong username/password.

[Patchcoat]

I have a fix using keytool and it works.

I'm not ready to submit a pull request due to performance concerns. It is quite slow and causing an unusable amount of UI lag. I'm going to try to optimize it, largely by moving keytool into a background task, and then it should be ready.

[frankhuurman]

I have a fix using keytool and it works. I'm not ready to submit a pull request due to performance concerns. It is quite slow and causing an unusable amount of UI lag. I'm going to try to optimize it, largely by moving keytool into a background task, and then it should be ready.

This would be a very nice improvement! thanks for your work on it :)

[Patchcoat]

This would be a very nice improvement! thanks for your work on it :)

Thanks. Regrettably it didn't pan out to a real-time check like shown in the screen shot because I couldn't figure out a good way to optimize it. I moved it to a pre-export check that will stop the export early if the password/username isn't correct and give you an error message telling you what's wrong.

[nightblade9]

Nice, thanks for fixing this! (Three years in the making 😁 )