Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Android keystore username and password are checked on export #83702

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Ensure Android keystore username and password are checked on export #83702

merged 1 commit into from
Jan 4, 2024

Conversation

Patchcoat
Copy link
Contributor

@Patchcoat Patchcoat commented Oct 20, 2023 •
edited
Loading

Fix for issue #27574.
When the user exports for android, the editor uses keytool to validate the username and password. If they aren't valid, it stops the export and presents the user with an error explaining what went wrong.

@Patchcoat Patchcoat requested a review from a team as a code owner October 20, 2023 22:25
@Calinou Calinou added this to the 4.x milestone Oct 20, 2023
@AThousandShips AThousandShips changed the title android keystore username and password are checked on export Ensure android keystore username and password are checked on export Oct 21, 2023
m4gr3d
m4gr3d approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the fix!

@m4gr3d m4gr3d modified the milestones: 4.x, 4.3 Nov 3, 2023
AThousandShips
AThousandShips reviewed Nov 3, 2023
View reviewed changes
platform/android/export/export_plugin.cpp Outdated Show resolved Hide resolved
platform/android/export/export_plugin.cpp Outdated Show resolved Hide resolved
platform/android/export/export_plugin.h Outdated Show resolved Hide resolved
platform/android/export/export_plugin.cpp Outdated Show resolved Hide resolved
platform/android/export/export_plugin.cpp Outdated Show resolved Hide resolved
@Patchcoat
Copy link
Contributor Author

Thanks for the style corrections. I've integrated them and flattened it all into one commit.

@akien-mga akien-mga changed the title Ensure android keystore username and password are checked on export Ensure Android keystore username and password are checked on export Jan 4, 2024
@akien-mga akien-mga merged commit 763a8e9 into godotengine:master Jan 4, 2024
15 checks passed
@akien-mga
Copy link
Member

akien-mga commented Jan 4, 2024 •
edited
Loading

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4gr3d m4gr3d m4gr3d approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
enhancement platform:android topic:export usability
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Export to Android fails with INSTALL_PARSE_FAILED_NO_CERTIFICATES if debug keystore unspecified
5 participants
@Patchcoat @akien-mga @m4gr3d @AThousandShips @Calinou