-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor ignoring Ctrl + Shortcuts after losing focus while holding Right Alt #28511
Comments
Likely fixed by #28465. Could you try with latest master ? |
@akien-mga ah indeed. |
I can confirm, it's not the same issue as #28465. Pressing control doesn't fix the problem, and pressing S doesn't save. The only way to fix it is to completely exit Godot, but that only fixes it for a few minutes at most. |
Can confirm as well. I'm running the latest 3.1.1.stable. When it's in this borked state, I noticed that CTRL+C will actually clear highlighted text in the editor. Basically you can't trust any CTRL+ key combo after the bug rears its head. Restarting the editor fixes the issue temporarily, as @mostlysoftware describes. |
@amisner2k Which operating system are you on? This bug could be OS-specific. |
Good call. I'm on Windows 10. |
This is really bizarre, has no one else reported this or do not very many people use the keyboard shortcuts involving the CTRL key? @Calinou , were you able to reproduce this? |
@amisner2k I haven't been able to reproduce this on Linux. Maybe this is caused by accumulated input (similar to #27104)? To verify this, download the Godot source code, change the Line 5441 in 24e1039
See Compiling for Windows for instructions on how to compile Godot from source. |
Ok, that is a good idea and something I'd like to do sometime in the near future. However, if someone on here already has 3.1.1.stable compiled and working on their Windows machine, then It'd be awesome if they could try flipping that |
Just wanted to add that I did something I'm guessing others have done to work around this issue: remap some of the shortcuts to not use the Ctrl key. However, when I did that, I noticed that it also seemed to fix the issue altogether. Before when the bug occurred, any shortcut key involving Ctrl would be mixed up. Ctrl+C would end up clearing an entire line in the Script Text editor for example, it was crazy. After I remapped Ctrl+S and Ctrl+Shift+S to simply be Alt+S and Alt+Shift+S, the Ctrl key would work again in the Script Text editor (I didn't have to restart Godot or anything). Very weird but for now, the workarounds aren't bad at all. I still look forward to building Godot from source in the future and maybe this bug, if it still exists, will be my first adventure. This engine is quite simply...amazing. |
Ok, so I discovered that the bug occurs consistently and the thing that triggers it is Alt+Tabbing away from Godot. So repro is:
So something is going on with the Alt+Tab key combination in Godot. If I find time to build Godot's source myself, I'll dig further, but hopefully someone else more experienced can take up the mantle and find the issue quicker than I can. |
Another update: |
This problem has really been bugging me, and I hadn't even considered that Alt+Tab might be the issue. I use that a lot, so it's no wonder than I kept running into this bug. Great insight and workaround, @amisner2k ! I tested the suggestion from @Calinou for changing that value from |
Thank you for taking the time to verify that @cur33, at least we can rule that out as a possible solution. And yeah, fortunately the workaround is quick and easy. :) |
@amisner2k and others, the plot thickens: I've noticed that this issue only occurs when I use the right Alt button on my keyboard, and never the left. If I Alt-Tab away using with the left Alt (not something I usually do, which is why I haven't noticed til now), and then return to Godot, Ctrl+ shortcuts still work as expected. However, if I Alt-Tab away with the right Alt then return to Godot, I have to use the workaround of pressing right Alt (pressing left Alt does not fix it) before the Ctrl+ shortcuts work again. For context, I'm on Windows 10, and confirmed this behavior on both 3.1.1 Stable (Mono) and 3.2 Stable (Mono); I just upgraded today. I'd love to tackle this issue myself, but I don't really have the time right now and I've never contributed to Godot before so I'm not all that familiar with the codebase (although I do have C++ experience, so that helps). But since it's relatively low priority, then I'll definitely see if I can shed any light on this if the issue is still open when I have more time. |
I also am having this in the latest 3.2 with win 10. Doesn't happen often, so I prematurely closed my issue #35844. I recently had it happen when tabbing back into the editor. What I noticed was the script editor file menu was reduced to only File. Tabbing in and out again made the other elements return, and the shortcuts returned. Not 100% though if it's the same issue, or if another exists regarding gui not being completely restored. For those that can reliably reproduce it, you might see if other shortcuts are affected from the same areas as the CTRL+ ones you are using. |
I get an issue like this a lot. Ctrl+C cuts text. Currently I'm using 3.3.3 stable but I've had it across multiple versions. This happens to me many times a day and I'm always restarting Godot because of it. If anyone wants me to set any breakpoints or test out other hotkeys I can. |
@cur33 is correct. #28511 (comment) The The Ctrl keys do not break when switching to another app with: WorkaroundPress the Reproduction steps
ObservedMost of the These work as expected: But these don't work the same as when the Ctrl key bindings are not broken. The following key bindings change the colors of the 3d view menu buttons,
ExpectedThe NotesIt isn't limited to the 3D Scene node, it happens with any node. SystemGodot Windows 21H1 This is reproducible with a clean setup. |
That information clears things up for me. If you are holding What's probably happening is that I have a program on my computer that opens a dialogue window on Knowing that pressing right alt fixes this saves me a ton of time. |
Can still reproduce in 532e253 using the Right Alt, but I never use this key so the issue never triggered for me accidentally. |
I am using windows with a custom keybinding that opens a window for All that is needed to replicate the bug is to hold My keyboard layout is standard English QWERTY |
Thanks, that's the most concise reproducer EDIT: So I was misled, my Right Alt is configured as the Compose key on my system, which acts like a dead key to form advanced characters. That's why it eats up the next two inputs, it's unrelated to holding it / losing focus and thus not this bug at all. So I'm back to thinking this is probably Windows specific. Invalid attempt at reproducing on LinuxHere's how I reproduce it reliably:
|
In Windows 10, after unfocusing Godot with Nothing changes when one continues to press Pressing and releasing |
For me |
Edited my previous post, my test was wrong on Linux, the symptoms I saw were just due to using the Right Alt key as Compose key. If I remove the config for it to be the Compose key, I can't reproduce this bug. |
How are you testing that? For me in |
For me |
@duianto In your report, you mention that you are switching to another application with right alt-tab, but on Windows 10 with US Qwerty, this is simply not possible (Only left-alt tab is supported). Do you have something else installed that is allowing this? I just tried to no avail on same setup (Windows 10 and US Qwerty) and I can't reproduce the issue in any way, nor I can't switch windows with right-alt + tab. |
For me, Holding down one of the Pressing Releasing the Could it be a physical keyboard issue?, the right alt key on my keyboard says |
Nevermind I can reproduce the issue now, it failed because I am using Synergy. Connecting a keyboard directly works. |
Fix incoming ⬆️ |
I have complied with the |
Confirmed in: v4.0.beta.custom_build [a5ccff194] |
Fixes godotengine#28511. (cherry picked from commit e01452a)
Fixes godotengine#28511. (cherry picked from commit e01452a)
Fixes godotengine#28511. (cherry picked from commit e01452a)
Godot version:
3.1.1 Stable Win 64
OS/device including version:
Windows 10 Version 10.0.17763 Build 17763
Issue description:
Godot will randomly stop accepting any shortcut that uses the CTRL key. For example, pressing "CTRL+S" will switch to the scale tool instead of saving. Restarting Godot will fix it for either 5 seconds or 5 minutes.
Pressing control does cause the ruler to change, so it knows the key is being pressed. It's just ignoring it in combination with other keys.
I've tried updating windows, nuking my app data, upgrading godot, running as admin, compatibility settings, a different computer, sticky key settings, and whatever else I could think of.
Steps to reproduce:
I've been pulling my hair out trying to figure out what causes it. Sometimes it seems to happen after a parsing error. Sometimes it happens on its own. I can reproduce it on both of my laptops (surface go and hp spectre x360 15), but not on command. It has a mind of its own.
Minimal reproduction project:
Happens on any type of project. I've managed to trigger this on a brand new project with only 1 node and 1 script.
The text was updated successfully, but these errors were encountered: