Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphEdit's AddValidConnectionType args are reversed #34420

Closed
ghost opened this issue Dec 18, 2019 · 3 comments · Fixed by #60124
Closed

GraphEdit's AddValidConnectionType args are reversed #34420

ghost opened this issue Dec 18, 2019 · 3 comments · Fixed by #60124
Milestone

Comments

@ghost
Copy link

ghost commented Dec 18, 2019

Godot version:
269145a Mono
OS/device including version:
ArcoLinux
Issue description:
AddValidConnectionType takes two arguments: fromType, and then toType. However, in order to get a right-side slot (from) to connect with a left-side slot(to), you actually have to supply the arguments in the reverse order: toType first, then fromType, despite the argument names. These should probably be swapped around, or renamed.

I'm not sure if GDScript also has this same issue or if it's another C# inconsistency.

@sheshire63
Copy link

in gd script it allows the connection if you start the connection from the "to" slot type regardless of left or right side
therefore if you allow a connection from slot type 0 to slot type 1 you connect it both ways if you start with the slot type 1

@akien-mga
Copy link
Member

CC @godotengine/gui-nodes

@KoBeWi
Copy link
Member

KoBeWi commented Apr 3, 2022

Yep, seems like they are really reversed. Not sure why there weren't other reports about it, but it doesn't affect visual editors, because connections are two-way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants