Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor crashes on startup [regression from ObjectID refactor] #36246

Closed
timothyqiu opened this issue Feb 15, 2020 · 4 comments · Fixed by #36358
Closed

Editor crashes on startup [regression from ObjectID refactor] #36246

timothyqiu opened this issue Feb 15, 2020 · 4 comments · Fixed by #36358
Assignees
@reduz
Labels
bug confirmed crash regression topic:editor
Milestone
4.0

Comments

@timothyqiu
Copy link
Member

Godot version: 4.0.dev.custom_build.264f20f8c

OS/device including version: macOS 10.15.2

Issue description:
The editor crashes on startup. This happens after the object-id refactorization.

* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
  * frame #0: 0x00007fff707a07fa libsystem_kernel.dylib`__pthread_kill + 10
    frame #1: 0x00007fff7085dbc1 libsystem_pthread.dylib`pthread_kill + 432
    frame #2: 0x00007fff70727a1c libsystem_c.dylib`abort + 120
    frame #3: 0x00007fff7081d647 libsystem_malloc.dylib`malloc_vreport + 548
    frame #4: 0x00007fff7082040e libsystem_malloc.dylib`malloc_report + 151
    frame #5: 0x000000010378f611 godot.osx.tools.64`Memory::free_static(p_ptr=0x000000011836bd20, p_pad_align=false) at memory.cpp:178:3
    frame #6: 0x00000001035bba90 godot.osx.tools.64`void memdelete<Object>(p_class=0x000000011836bd20) at memory.h:119:2
    frame #7: 0x00000001035127d6 godot.osx.tools.64`ClassDB::class_get_default_property_value(p_class=0x00007ffeefbf7660, p_property=0x00007ffeefbf7658, r_valid=0x00007ffeefbf766f) at class_db.cpp:1431:5
    frame #8: 0x0000000101bb991f godot.osx.tools.64`get_documentation_default_value(p_class_name=0x00007ffeefbf7660, p_property_name=0x00007ffeefbf7658, r_default_value_valid=0x00007ffeefbf766f) at doc_data.cpp:214:19
    frame #9: 0x0000000101bb3fa1 godot.osx.tools.64`DocData::generate(this=0x0000000117c53f60, p_basic_types=true) at doc_data.cpp:297:21
    frame #10: 0x00000001017190d1 godot.osx.tools.64`EditorHelp::generate_doc() at editor_help.cpp:1459:7
    frame #11: 0x00000001017b962a godot.osx.tools.64`EditorNode::EditorNode(this=0x000000010a14f210) at editor_node.cpp:5611:2
    frame #12: 0x00000001017d8175 godot.osx.tools.64`EditorNode::EditorNode(this=0x000000010a14f210) at editor_node.cpp:5598:26
    frame #13: 0x000000010004b570 godot.osx.tools.64`Main::start() at main.cpp:1748:18
    frame #14: 0x000000010001e483 godot.osx.tools.64`main(argc=4, argv=0x00007ffeefbff7c0) at godot_main_osx.mm:78:6
    frame #15: 0x00007fff706597fd libdyld.dylib`start + 1

Some log before the crash:

2020-02-15 22:53:52.080692+0800 godot.osx.tools.64[13284:8850686] ERROR: Method definition provides more arguments than the method actually has 'VisualServer::environment_set_ssao'.
at: bind_methodfi (core/class_db.cpp:1264)
ERROR: Method definition provides more arguments than the method actually has 'VisualServer::environment_set_ssao'.
   at: bind_methodfi (core/class_db.cpp:1264)
2020-02-15 22:53:52.082299+0800 godot.osx.tools.64[13284:8850686] ERROR: Method/Function Failed.
at: bind_integer_constant (core/class_db.cpp:700)
ERROR: Method/Function Failed.
   at: bind_integer_constant (core/class_db.cpp:700)
2020-02-15 22:53:52.082330+0800 godot.osx.tools.64[13284:8850686] ERROR: Method/Function Failed.
at: bind_integer_constant (core/class_db.cpp:700)
ERROR: Method/Function Failed.
   at: bind_integer_constant (core/class_db.cpp:700)
2020-02-15 22:53:52.082346+0800 godot.osx.tools.64[13284:8850686] ERROR: Method/Function Failed.
at: bind_integer_constant (core/class_db.cpp:700)
ERROR: Method/Function Failed.
   at: bind_integer_constant (core/class_db.cpp:700)
compilation success
2020-02-15 22:53:52.124394+0800 godot.osx.tools.64[13284:8850686] [plugin] AddInstanceForFactory: No factory registered for id <CFUUID 0x109481f80> F8BB1C28-BAE8-11D6-9C31-00039315CD46
2020-02-15 22:53:52.151097+0800 godot.osx.tools.64[13284:8850686]  HALC_ShellDriverPlugIn::Open: Can't get a pointer to the Open routine
2020-02-15 22:53:52.151548+0800 godot.osx.tools.64[13284:8850686]  HALC_ShellDriverPlugIn::Open: Can't get a pointer to the Open routine

[mvk-info] Created 3 swapchain images with initial size (2560, 1510).
2020-02-15 22:53:52.352070+0800 godot.osx.tools.64[13284:8850686] [plugin] AddInstanceForFactory: No factory registered for id <CFUUID 0x117bd4ec0> 30010C1C-93BF-11D8-8B5B-000A95AF9C6A
2020-02-15 22:53:52.367573+0800 godot.osx.tools.64[13284:8850686] [plugin] AddInstanceForFactory: No factory registered for id <CFUUID 0x117bd4ec0> 30010C1C-93BF-11D8-8B5B-000A95AF9C6A
Registered camera FaceTime HD Camera with id 1 position 0 at index 0
2020-02-15 22:53:52.653513+0800 godot.osx.tools.64[13284:8850686] ERROR: Condition "p_elem->_root != this" is true.
at: remove (./core/self_list.h:84)
ERROR: Condition "p_elem->_root != this" is true.
   at: remove (./core/self_list.h:84)
2020-02-15 22:53:52.653554+0800 godot.osx.tools.64[13284:8850686] ERROR: Condition "object_slots[slot].object != p_object" is true.
at: remove_instance (core/object.cpp:2084)
ERROR: Condition "object_slots[slot].object != p_object" is true.
   at: remove_instance (core/object.cpp:2084)
2020-02-15 22:53:52.653568+0800 godot.osx.tools.64[13284:8850686] ERROR: Condition "!_p" is true.
at: _unref (core/dictionary.cpp:185)
ERROR: Condition "!_p" is true.
   at: _unref (core/dictionary.cpp:185)
godot.osx.tools.64(13284,0x109107dc0) malloc: *** error for object 0x117eecb60: pointer being freed was not allocated
godot.osx.tools.64(13284,0x109107dc0) malloc: *** set a breakpoint in malloc_error_break to debug

The project manager can start successfully, but crashes on exit.

Steps to reproduce:
Run godot using /path/to/godot -e --path /path/to/project

Minimal reproduction project: Any
@AndreaCatania
Copy link
Contributor

AndreaCatania commented Feb 15, 2020 •
edited
Loading

The crash is caused by this: 867d073

@akien-mga akien-mga added this to the 4.0 milestone Feb 15, 2020
@akien-mga akien-mga changed the title Editor crashes on startup Editor crashes on startup [regression from ObjectID refactor] Feb 15, 2020
@bruvzg
Copy link
Member

bruvzg commented Feb 15, 2020

I can confirm this. PM crashed on exit with the following stack trace:

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
  ???                           	0x00007fb565f38270 0 + 140417076265584
  godot_vlk                     	0x000000010cc1ad99 Object::_predelete() + 41 (object.cpp:386)
  godot_vlk                     	0x000000010cc2cae5 predelete_handler(Object*) + 21 (object.cpp:1996)
  godot_vlk                     	0x000000010cc7a495 void memdelete<_Marshalls>(_Marshalls*) + 21 (memory.h:114)
  godot_vlk                     	0x000000010cc7a023 unregister_core_types() + 83 (register_core_types.cpp:275)
  godot_vlk                     	0x00000001096a0582 Main::cleanup() + 1010 (main.cpp:2270)
  godot_vlk                     	0x000000010966dce8 main + 1032 (godot_main_osx.mm:79)
  libdyld.dylib                 	0x00007fff653df7fd start + 1

@ffaristocrat
Copy link
Contributor

I've run into the same issue as well after building from source.

@Chaosus Chaosus mentioned this issue Feb 16, 2020
Closed
@Calinou Calinou mentioned this issue Feb 16, 2020
Closed
@AndreaCatania
Copy link
Contributor

This crash seems related to: #36298

also notice: #36295

@akien-mga akien-mga mentioned this issue Feb 19, 2020
Closed
@vnen vnen mentioned this issue Feb 19, 2020
Merged
@akien-mga akien-mga mentioned this issue Feb 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reduz reduz

Labels
bug confirmed crash regression topic:editor
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Remove static script reference from GDScript class vnen/godot
Fix startup crash Chaosus/godot
7 participants
@Calinou @timothyqiu @ffaristocrat @akien-mga @reduz @bruvzg @AndreaCatania