Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix startup crash #36270

Closed
wants to merge 1 commit into from
Closed

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Feb 16, 2020

I detected the crash source using VisualStudio debugger, at least editor will run after this. I think it's not a correct fix - memdelete call should be checked by @reduz. But if someone need a worked build right now - you can use it. Fix #36246.

@Chaosus Chaosus added this to the 4.0 milestone Feb 16, 2020
@Chaosus Chaosus requested a review from reduz February 16, 2020 15:21
@akien-mga akien-mga requested a review from bojidar-bg February 16, 2020 16:19
@madmiraal
Copy link
Contributor

Although the crash is happening when memdelete(c) is called, this memory does need to be freed to prevent a memory leak; so you're right, this is not the correct fix.

@Chaosus
Copy link
Member Author

Chaosus commented Feb 16, 2020

Yeah, accept it as a bandage for impatient users.. tomorrow Juan will fix it properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor crashes on startup [regression from ObjectID refactor]
2 participants